Revert 5412 url reader special chars#5785
Closed
ales-erjavec wants to merge 2 commits intobiolab:masterfrom
Closed
Revert 5412 url reader special chars#5785ales-erjavec wants to merge 2 commits intobiolab:masterfrom
ales-erjavec wants to merge 2 commits intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
- Coverage 86.12% 86.12% -0.01%
==========================================
Files 316 316
Lines 66400 66384 -16
==========================================
- Hits 57189 57174 -15
+ Misses 9211 9210 -1 |
VesnaT
reviewed
Jan 14, 2022
| # tolerant parse, also prevent parsing as local file | ||
| parsed = QUrl.fromUserInput(url, os.devnull) | ||
| if parsed.isValid(): | ||
| url = bytes(parsed.toEncoded()).decode("ascii") |
Contributor
There was a problem hiding this comment.
The problem of this solution is, that the UrlReader itself still doesn't work, so the change would have to be made in every widget that uses it.
I'd rather the fix was made within the UrlReader.
Contributor
Author
There was a problem hiding this comment.
No. UrlReader should not accept invalid urls and should not do anything that could break valid urls.
Member
There was a problem hiding this comment.
Yes, but valid at which level? Shouldn't we support URLs as a browser would? If there is some non-destructive encoding/decoding happening in the background, why not put it into UrlReader?
ales-erjavec
force-pushed
the
revert-5412-url_reader_special_chars
branch
from
476e645 to
97d6057
Compare
ales-erjavec
force-pushed
the
revert-5412-url_reader_special_chars
branch
from
97d6057 to
116d392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5723
Description of changes
Includes